lkml.org 
[lkml]   [2013]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.
Hello.

On 18-03-2013 16:29, Venu Byravarasu wrote:

> As GPIO information is avail through DT, used it to get Tegra ULPI
> reset GPIO number. Added a new member to tegra_usb_phy structure to
> store this number.

> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
> ---
> drivers/usb/phy/tegra_usb_phy.c | 25 +++++++++++--------------
> include/linux/usb/tegra_usb_phy.h | 1 +
> 2 files changed, 12 insertions(+), 14 deletions(-)

> diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c
> index b5b2037..29c5ac4 100644
> --- a/drivers/usb/phy/tegra_usb_phy.c
> +++ b/drivers/usb/phy/tegra_usb_phy.c
[...]
> @@ -622,18 +619,18 @@ static int tegra_phy_init(struct usb_phy *x)
[...]
> - gpio_request(ulpi_config->reset_gpio, "ulpi_phy_reset_b");
> - gpio_direction_output(ulpi_config->reset_gpio, 0);
> + gpio_request(phy->reset_gpio, "ulpi_phy_reset_b");
> + gpio_direction_output(phy->reset_gpio, 0);

Why not use goio_request_one() instead of these two? Thought maybe it's a
material of another patch...

WBR, Sergei



\
 
 \ /
  Last update: 2013-03-18 14:41    [W:0.417 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site