Messages in this thread | | | Date | Mon, 18 Mar 2013 17:01:35 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT. |
| |
Hello.
On 18-03-2013 16:29, Venu Byravarasu wrote:
> As GPIO information is avail through DT, used it to get Tegra ULPI > reset GPIO number. Added a new member to tegra_usb_phy structure to > store this number.
> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com> > --- > drivers/usb/phy/tegra_usb_phy.c | 25 +++++++++++-------------- > include/linux/usb/tegra_usb_phy.h | 1 + > 2 files changed, 12 insertions(+), 14 deletions(-)
> diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c > index b5b2037..29c5ac4 100644 > --- a/drivers/usb/phy/tegra_usb_phy.c > +++ b/drivers/usb/phy/tegra_usb_phy.c [...] > @@ -622,18 +619,18 @@ static int tegra_phy_init(struct usb_phy *x) [...] > - gpio_request(ulpi_config->reset_gpio, "ulpi_phy_reset_b"); > - gpio_direction_output(ulpi_config->reset_gpio, 0); > + gpio_request(phy->reset_gpio, "ulpi_phy_reset_b"); > + gpio_direction_output(phy->reset_gpio, 0);
Why not use goio_request_one() instead of these two? Thought maybe it's a material of another patch...
WBR, Sergei
| |