| From | Andi Kleen <> | Subject | Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone() | Date | Sun, 17 Mar 2013 07:55:54 -0700 |
| |
Mel Gorman <mgorman@suse.de> writes:
> + > + /* > + * We put equal pressure on every zone, unless one zone has way too > + * many pages free already. The "too many pages" is defined as the > + * high wmark plus a "gap" where the gap is either the low > + * watermark or 1% of the zone, whichever is smaller. > + */ > + balance_gap = min(low_wmark_pages(zone), > + (zone->managed_pages + KSWAPD_ZONE_BALANCE_GAP_RATIO-1) / > + KSWAPD_ZONE_BALANCE_GAP_RATIO);
Don't like those hard coded tunables. 1% of a 512GB node can be still quite a lot. Shouldn't the low watermark be enough?
-Andi -- ak@linux.intel.com -- Speaking for myself only
|