| Date | Sat, 16 Mar 2013 11:39:52 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values |
| |
On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: > if (ret) { > dev_err(bg_ptr->dev, "failed to read thot\n"); > - return -EIO; > + ret = -EIO; > + goto exit; > } > > - *thot = temp; > + *val = temp; > > +exit: > return 0; > }
The bunny hop has introduced a bug and this always returns success.
regards, dan carpenter
|