lkml.org 
[lkml]   [2013]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 5/5] ARM: tegra: add spi nodes to Tegra114 DT
On Saturday 16 March 2013 12:12 AM, Stephen Warren wrote:
> On 03/13/2013 01:49 PM, Laxman Dewangan wrote:
>> NVIDIA's Tegra114 has 6 spi controllers. These controllers are
>> redesign on T114 with different register interface.
>> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
>> + reg = <0x7000d400 0x200>;
> ...
>> + reg = <0x7000d600 0x200>;
> ...
>> + reg = <0x7000d480 0x200>;
> ...
>> + reg = <0x7000da00 0x200>;
> ...
>> + reg = <0x7000dc00 0x200>;
> ...
>> + reg = <0x7000de00 0x200>;
> I assume that third entry should be 0x7000d800 not 0x7000d480; the TRM
> certainly thinks so. I fixed this up when I applied this patch.

Yes, this is bug in my patch and unfortunately exist in tegra20 and
tegra30 also.

grep d480 tegra*
tegra114.dtsi: reg = <0x7000d480 0x200>;
tegra20.dtsi: reg = <0x7000d480 0x200>;
tegra30.dtsi: reg = <0x7000d480 0x200>;

We need to fix this. I will post a patch now to correct it.


>
> I've applied the series to Tegra's for-3.10/dt branch. I made a few
> node/property ordering changes for consistency, and some capitalization
> fixes in the commit subjects/descriptions.

Thank you very much for taking care of this.


\
 
 \ /
  Last update: 2013-03-15 20:23    [W:0.044 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site