lkml.org 
[lkml]   [2013]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH]Skip unnecessary WARN_ON in panic case
Date
Thank you for giving me the feedback.

>
> So it appears the problem occurs because the other CPUs are not offlined correctly, and still have pending work which may generate
> wakeup IPIs to them?

Right.

>
> The fix would be to either offline them properly - or, if we don't want to do that to keep panicking simple, why do we mark them
> offline? They aren't really offline in a proper way.

To offline cpus properly, it should be done with threads like stop_machine().
But I don't think it is reasonable to kick the threads in panic case.
Therefore, I will make a patch keeping cpus online.
Also, to inform a panicked cpu that other cpus stopped surely,
I will introduce a new cpu_mask like cpu_stopped_mask.

Seiji


\
 
 \ /
  Last update: 2013-03-15 17:21    [W:0.066 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site