Messages in this thread | | | Date | Thu, 14 Mar 2013 09:21:10 +0000 | From | James Hogan <> | Subject | Re: [PATCH 1/1] module: fix symbol versioning with symbol prefixes |
| |
On 13/03/13 23:51, Rusty Russell wrote: > James Hogan <james.hogan@imgtec.com> writes: >> Fix symbol versioning on architectures with symbol prefixes. Although >> the build was free from warnings the actual modules still wouldn't load >> as the ____versions table contained unprefixed symbol names, which were >> being compared against the prefixed symbol names when checking the >> symbol versions. >> >> This is fixed by modifying modpost to add the symbol prefix to the >> ____versions table it outputs (Modules.symvers still contains unprefixed >> symbol names). The check_modstruct_version() function is also fixed as >> it checks the version of the unprefixed "module_layout" symbol which >> would no longer work. > > Hmm, this has always been broken, right? And noone noticed? Unless you > really want it now, I'll queue it for *next* merge window.
Yes, that's fine by me.
> I've applied it (reworked) to my pending-rebases queue, and will put it > in modules-next once the cleanup goes in.
Thanks James
| |