Messages in this thread | | | Date | Wed, 13 Mar 2013 13:51:47 -0700 | From | Tejun Heo <> | Subject | Re: linux-next: manual merge of the akpm tree with the workqueues tree |
| |
Hello, Andrew.
On Wed, Mar 13, 2013 at 12:46:24PM -0700, Andrew Morton wrote: > Tejun, can you please confirm that this is how worker_pool_assign_id() > should look in linux-next? > > static int worker_pool_assign_id(struct worker_pool *pool) > { > int ret; > > do { > idr_preload(GFP_KERNEL); > spin_lock_irq(&workqueue_lock); > ret = idr_alloc(&worker_pool_idr, pool, 0, 0, GFP_NOWAIT); > if (ret >= 0) > pool->id = ret; > spin_unlock_irq(&workqueue_lock);
idr_preload_end();
> } while (ret == -EAGAIN); > > return ret < 0 ? ret : 0; > }
Other than that, it looks good to me.
Thanks!
-- tejun
| |