lkml.org 
[lkml]   [2013]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system
On Tue, Mar 12, 2013 at 02:42:15PM -0700, Andrew Morton wrote:
> On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu <liuj97@gmail.com> wrote:
>
> > Use helper function free_highmem_page() to free highmem pages into
> > the buddy system.
> >
> > ...
> >
> > --- a/arch/sparc/mm/init_32.c
> > +++ b/arch/sparc/mm/init_32.c
> > @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn)
> > printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn);
> > #endif
> >
> > - for (tmp = start_pfn; tmp < end_pfn; tmp++) {
> > - struct page *page = pfn_to_page(tmp);
> > -
> > - ClearPageReserved(page);
> > - init_page_count(page);
> > - __free_page(page);
> > - totalhigh_pages++;
> > - }
> > + for (tmp = start_pfn; tmp < end_pfn; tmp++)
> > + free_higmem_page(pfn_to_page(tmp));
> > }
>
> This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK
> because CONFIG_HIGHMEM=n isn't possible on sparc32.
Correct - from arch/sparc/Kconfig

config HIGHMEM
bool
default y if SPARC32


> This patch and one other mistyped "free_highmem_page". I got lazy and
> edited those patches in-place.
Good spot!

You can add my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Sam



\
 
 \ /
  Last update: 2013-03-13 15:44    [W:0.262 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site