Messages in this thread Patch in this message | | | From | Greg Kroah-Hartman <> | Subject | [ 10/21] md: raid0: fix error return from create_stripe_zones. | Date | Tue, 12 Mar 2013 15:44:12 -0700 |
| |
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: NeilBrown <neilb@suse.de>
commit 58ebb34c49fcfcaa029e4b1c1453d92583900f9a upstream.
Create_stripe_zones returns an error slightly differently to raid0_run and to raid0_takeover_*.
The error returned used by the second was wrong and an error would result in mddev->private being set to NULL and sooner or later a crash.
So never return NULL, return ERR_PTR(err), not NULL from create_stripe_zones.
This bug has been present since 2.6.35 so the fix is suitable for any kernel since then.
Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/md/raid0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/md/raid0.c +++ b/drivers/md/raid0.c @@ -283,7 +283,7 @@ abort: kfree(conf->strip_zone); kfree(conf->devlist); kfree(conf); - *private_conf = NULL; + *private_conf = ERR_PTR(err); return err; }
| |