lkml.org 
[lkml]   [2013]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subjectpowerpc/eeh: Fix compile error due to missing include file
    Date
    Ben Hutchings <ben@decadent.org.uk> wrote:

    > On Fri, 2013-03-08 at 13:51 +1100, Michael Neuling wrote:
    > > This patch is breaking the celleb_defconfig on powerpc with:
    > >
    > > arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe':
    > > arch/powerpc/kernel/of_platform.c:95:2: error: implicit declaration of
    > > function 'eeh_add_sysfs_files' [-Werror=implicit-function-declaration]
    >
    > In 3.2 this file doesn't (directly) include <asm/eeh.h> which is where
    > the definition was added. In mainline it does.
    >
    > Assuming that this change is actually required for 3.2 (which I'm not
    > sure about), I suppose we just need to add the #include.

    Yep that fixes it. Patch below (for stable 3.2 only)


    From: Michael Neuling <mikey@neuling.org>
    Subject: powerpc/eeh: Fix compile error due to missing include file

    3.2.40 fails to compile the celleb_defconfig with the following error:

    arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe':
    arch/powerpc/kernel/of_platform.c:95:2: error: implicit declaration of function 'eeh_add_sysfs_files' [-Werror=implicit-function-declaration]

    The following adds the required include file to fix this.

    Signed-off-by: Michael Neuling <mikey@neuling.org>

    diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
    index b10beef..601650f 100644
    --- a/arch/powerpc/kernel/of_platform.c
    +++ b/arch/powerpc/kernel/of_platform.c
    @@ -26,6 +26,7 @@
    #include <asm/topology.h>
    #include <asm/pci-bridge.h>
    #include <asm/ppc-pci.h>
    +#include <asm/eeh.h>
    #include <linux/atomic.h>

    #ifdef CONFIG_PPC_OF_PLATFORM_PCI

    \
     
     \ /
      Last update: 2013-03-12 07:22    [W:3.009 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site