Messages in this thread | | | Subject | Re: [PATCH 12/18] driver: scsi: remove cast for kmalloc/kzalloc return value | From | Joe Perches <> | Date | Tue, 12 Mar 2013 09:32:53 -0700 |
| |
On Tue, 2013-03-12 at 09:27 +0000, James Bottomley wrote: > On Tue, 2013-03-12 at 13:25 +0800, Zhang Yanfei wrote: > > remove cast for kmalloc/kzalloc return value. > > I've got to ask why? Just because void * can be assigned to any pointer > doesn't mean we should religiously eliminate all casts of void *. If > the driver writer believes there's value making sure of the pointer > type, I'm happy to keep the cast.
This view is why scsi has many different styles instead of a more consistent kernel style.
For the cciss/hpsa example shown:
Do you suggest indirecting structs with typedefs like BIG_IOCTL_Command_struct is a good thing as well because the driver writer thinks it so?
| |