lkml.org 
[lkml]   [2013]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv3] perf: Fix vmalloc ring buffer free function
From
Date
On Tue, 2013-03-12 at 14:52 +0100, Jiri Olsa wrote:
> > @@ -373,7 +373,7 @@ struct ring_buffer *rb_alloc(int nr_pages, long watermark, int cpu, int flags)
> > rb->user_page = all_buf;
> > rb->data_pages[0] = all_buf + PAGE_SIZE;
> > rb->page_order = ilog2(nr_pages);
> > - rb->nr_pages = 1;
> > + rb->nr_pages = nr_pages;
> >
>
> hum, and this ^^^ breaks perf_data_size(rb) ;)
>
> static inline unsigned long perf_data_size(struct ring_buffer *rb)
> {
> return rb->nr_pages << (PAGE_SHIFT + page_order(rb));
> }

How so? 0 << n keeps being 0, right?



\
 
 \ /
  Last update: 2013-03-12 17:01    [W:1.769 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site