Messages in this thread | | | Date | Tue, 12 Mar 2013 16:28:14 +0200 | From | Roger Quadros <> | Subject | Re: [PATCH 1/8] usb: phy: nop: Add some parameters to platform data |
| |
On 03/12/2013 04:17 PM, Marc Kleine-Budde wrote: > On 03/12/2013 03:12 PM, Roger Quadros wrote: >> On 03/12/2013 01:54 PM, Marc Kleine-Budde wrote: >>> On 03/12/2013 12:24 PM, Roger Quadros wrote: >>>> Add clk_rate parameter to platform data. If supplied, the >>>> NOP phy driver will program the clock to that rate during probe. >>>> >>>> Also add 2 flags, needs_vcc and needs_reset. >>>> If the flag is set and the regulator couldn't be found >>>> then the driver will bail out with -EPROBE_DEFER. >>> >>> Is there a platform which fills out pdata.needs_vcc and >>> pdata.needs_reset? IMHO it makes no sense to add features for the non DT >>> case, if there isn't any user for it. >>> >> >> There can be a user in the non DT case as well. Consider the following example: > > I'm just saying, let the implementation up to a real user for the non DT > case. Beagleboard is ARM and there's no point of implementing non DT > fall backs for ARM, IMHO. >
Why do you say so?
It doesn't depend on the CPU architecture. It depends on how the board designer wired the board. A non ARM platform could also face the same problem as beagle.
It is not a non DT fallback. I believe many are still using non DT boot and it needs to work at least till we move all functionality to purely DT.
cheers, -roger
| |