Messages in this thread | | | Date | Tue, 12 Mar 2013 06:34:46 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] device: separate all subsys mutexes (was: Re: [BUG] potential deadlock led by cpu_hotplug lock (memcg involved)) |
| |
On Tue, Mar 12, 2013 at 02:05:04PM +0100, Michal Hocko wrote: > The fix is quite simple. We can pull the key inside bus_type structure > because they are defined per device so the pointer will be unique as > well. bus_register doesn't need to be a macro anymore so change it > to the inline. We could get rid of __bus_register as there is no other > caller but maybe somebody will want to use a different key so keep it > around for now.
Nice work, but just drop __bus_register(), no one should need to use a new key for this type of thing, now that you have added a per-bus_type variable.
thanks,
greg k-h
| |