Messages in this thread | | | Date | Fri, 01 Mar 2013 07:29:17 +0100 | From | leroy christophe <> | Subject | Re: [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver |
| |
Le 01/03/2013 01:43, Linus Walleij a écrit : > On Fri, Feb 22, 2013 at 10:26 AM, Christophe Leroy > <christophe.leroy@c-s.fr> wrote: > >> This patch allows the use of the MAX730x Driver on systems using >> the Open Firmware platform format >> >> Signed-off-by: Patrick Vasseur <patrick.vasseur@c-s.fr> >> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> > (...) >> /* bits_per_word cannot be configured in platform data */ >> - spi->bits_per_word = 16; >> + if (spi->dev.platform_data) >> + spi->bits_per_word = 16; > What about just fixing so you *can* specify that instead? > The comment looks more like a FIXME to me. Euh, ok, why not. But here the purpose of my patch is to allow using this driver with of_platform in addition to platform. This FIXME is not mine, it was already existing in that driver. As of_platform can configure bits per word, the only thing I did is to add a test in order to not apply this FIXME on the of_platform case.
Do you think my patch is not acceptable like this ?
Regards Christophe
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |