Messages in this thread | | | Date | Fri, 1 Mar 2013 14:28:18 +0100 | From | Rickard Andersson <> | Subject | Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer |
| |
On 03/01/2013 09:56 AM, Vincent Guittot wrote: > On 1 March 2013 02:13, Linus Walleij<linus.walleij@linaro.org> wrote: >> On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano >> <daniel.lezcano@linaro.org> wrote: >> >>> Add the dynamic irq affinity feature to the timer clock device. >>> >>> Signed-off-by: Daniel Lezcano<daniel.lezcano@linaro.org> >> Looks reasonable to me, sadly I do not fully grasp the patch set, >> Vincent+Rickard can you have a look at this? > ux500 is able to trig the wake up on one CPU and let the other one in > WFI. This patch will minimize the spurious wake up of CPU0 when CPU1 > is the target CPU of the broadcast timer. One main consequence is that > we will not uselessly execute all the deferrable and newly idle > activities on the CPU0 . > > you can add my reviewed-by if you want > > Vincent > It looks ok to me as well.
BR Rickard
| |