Messages in this thread | | | Date | Fri, 1 Mar 2013 11:57:05 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] x86: change names of e820 memory map type |
| |
* li guang <lig.fnst@cn.fujitsu.com> wrote:
> gratuitous? > > It was inspired by gtk library's key definitions,
I don't think GTK is a shining example of API cleanliness and usability that the kernel should strive to imitate, especially not in the naming department...
> gtk original keys like GDK_1, GDK_2, GDK_p, GDK_q, GDK_tab ... > now they all be changed to GDK_KEY_1, GDK_KEY_2 ... > do you think it's reasonable? > or gratuitous?
I think hpa already expressed his opinion about the rename?
Thanks,
Ingo
| |