lkml.org 
[lkml]   [2013]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/16] ACPI / idle: pass the cpuidle_device parameter
    Date
    From: Daniel Lezcano <daniel.lezcano@linaro.org>

    The cpuidle_device is retrieved in the function by using directly
    the global variable. But the caller of this function already have
    this device and it can be passed as a parameter. That is one small
    step to encapsulate the code more.

    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Signed-off-by: Len Brown <len.brown@intel.com>
    ---
    drivers/acpi/processor_idle.c | 11 ++++++-----
    1 file changed, 6 insertions(+), 5 deletions(-)

    diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
    index 82626e9..6837065 100644
    --- a/drivers/acpi/processor_idle.c
    +++ b/drivers/acpi/processor_idle.c
    @@ -928,13 +928,14 @@ struct cpuidle_driver acpi_idle_driver = {
    * device i.e. per-cpu data
    *
    * @pr: the ACPI processor
    + * @dev : the cpuidle device
    */
    -static int acpi_processor_setup_cpuidle_cx(struct acpi_processor *pr)
    +static int acpi_processor_setup_cpuidle_cx(struct acpi_processor *pr,
    + struct cpuidle_device *dev)
    {
    int i, count = CPUIDLE_DRIVER_STATE_START;
    struct acpi_processor_cx *cx;
    struct cpuidle_state_usage *state_usage;
    - struct cpuidle_device *dev = per_cpu(acpi_cpuidle_device, pr->id);

    if (!pr->flags.power_setup_done)
    return -EINVAL;
    @@ -1089,7 +1090,7 @@ int acpi_processor_hotplug(struct acpi_processor *pr)
    cpuidle_disable_device(dev);
    acpi_processor_get_power_info(pr);
    if (pr->flags.power) {
    - acpi_processor_setup_cpuidle_cx(pr);
    + acpi_processor_setup_cpuidle_cx(pr, dev);
    ret = cpuidle_enable_device(dev);
    }
    cpuidle_resume_and_unlock();
    @@ -1147,8 +1148,8 @@ int acpi_processor_cst_has_changed(struct acpi_processor *pr)
    continue;
    acpi_processor_get_power_info(_pr);
    if (_pr->flags.power) {
    - acpi_processor_setup_cpuidle_cx(_pr);
    dev = per_cpu(acpi_cpuidle_device, cpu);
    + acpi_processor_setup_cpuidle_cx(_pr, dev);
    cpuidle_enable_device(dev);
    }
    }
    @@ -1217,7 +1218,7 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr)
    return -ENOMEM;
    per_cpu(acpi_cpuidle_device, pr->id) = dev;

    - acpi_processor_setup_cpuidle_cx(pr);
    + acpi_processor_setup_cpuidle_cx(pr, dev);

    /* Register per-cpu cpuidle_device. Cpuidle driver
    * must already be registered before registering device
    --
    1.8.1.3.535.ga923c31


    \
     
     \ /
      Last update: 2013-02-09 03:21    [W:2.191 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site