lkml.org 
[lkml]   [2013]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 08/26] iommu, irq: Allocate irq_desc for dmar_msi with local node
    Date
    iommu irq's irq_desc should be on local node ram.

    Fix the return value checking problem.

    create_irq() will return -1 when fail to allocate.
    create_irq_nr() will return 0 when fail to allocate.

    here only check !irq, so need to change it to use create_irq_nr instead.

    Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    Cc: Joerg Roedel <joro@8bytes.org>
    Cc: Donald Dutile <ddutile@redhat.com>
    ---
    drivers/iommu/dmar.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
    index 174bb65..316b5a2 100644
    --- a/drivers/iommu/dmar.c
    +++ b/drivers/iommu/dmar.c
    @@ -1263,7 +1263,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu)
    if (iommu->irq)
    return 0;

    - irq = create_irq();
    + irq = create_irq_nr(0, iommu->node);
    if (!irq) {
    pr_err("IOMMU: no free vectors\n");
    return -EINVAL;
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2013-02-08 21:22    [W:4.513 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site