lkml.org 
[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] clk: tegra: Implement locking for super clock
Date
Quoting Peter De Schrijver (2013-02-07 08:24:14)
> Although tegra_clk_register_super_mux() has a lock parameter, the lock is not
> actually used by the code. Fixed with this patch.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---
> drivers/clk/tegra/clk-super.c | 18 +++++++++++++++---
> 1 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-super.c b/drivers/clk/tegra/clk-super.c
> index 7ad48a8..2fd924d 100644
> --- a/drivers/clk/tegra/clk-super.c
> +++ b/drivers/clk/tegra/clk-super.c
> @@ -73,7 +73,12 @@ static int clk_super_set_parent(struct clk_hw *hw, u8 index)
> {
> struct tegra_clk_super_mux *mux = to_clk_super_mux(hw);
> u32 val, state;
> + int err = 0;
> u8 parent_index, shift;
> + unsigned long flags = 0;

I don't think initializing flags to zero is necessary but it is not a
big deal. Is gcc throwing a warning? Otherwise:

Acked-by: Mike Turquette <mturquette@linaro.org>

Regards,
Mike


\
 
 \ /
  Last update: 2013-02-07 21:02    [W:0.044 / U:1.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site