lkml.org 
[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller
    On Tue, Feb 05, 2013 at 03:09:43PM -0800, Girish K S wrote:
    > This patch adds support for spi controllers with
    > dedicated clk/miso/mosi/cs pins. It skips the gpio
    > parsing and initialization for controllers that
    > have dedicated pins.

    > if (sdd->tgl_spi != spi) { /* if last mssg on diff device */
    > /* Deselect the last toggled device */
    > cs = sdd->tgl_spi->controller_data;
    > - gpio_set_value(cs->line,
    > - spi->mode & SPI_CS_HIGH ? 0 : 1);
    > + if (!(sdd->port_conf->quirks & S3C64XX_SPI_QUIRK_GPIO))
    > + gpio_set_value(cs->line,
    > + spi->mode & SPI_CS_HIGH ? 0 : 1);
    > }

    This isn't going to work with system designs which ignore the /CS line
    the controller has and just use a GPIO instead. This is very common,
    for example when connecting multiple devices to the same SPI bus.

    It seems like there's really two changes here. One change is making the
    provision of pinmux information optional, the other is allowing the user
    to use the controller /CS management rather than using GPIO.


    \
     
     \ /
      Last update: 2013-02-07 13:41    [W:4.200 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site