Messages in this thread | | | Date | Tue, 5 Feb 2013 16:21:31 +0800 | From | Huang Shijie <> | Subject | Re: [PATCH 2/2] mtd: torturetest: add the support for random data pattern |
| |
于 2013年02月05日 16:05, Ricard Wanderlof 写道: > > On Tue, 5 Feb 2013, Huang Shijie wrote: > >> Add a new module parameter 'pattern'. If it is set to zero, we will >> use the 55/AA pattern to torture the nand blocks; if it is set to a >> non-zero value, we will use the random data pattern. > > Not a big issue in any way, but if you're using a numeric parameter > value anyway, could not one use a range of the permissable values to > set a seed for the random generation, so that the test can be repeated > with the same set of random numbers? It's ok to provide a seed to the mtd_torturetest.
> > Something like > > 0 => 55/AA > -1 => random > 1 and up => random, specifying seed for random number generator. > I will add it in next version.
thanks for your review.
Huang Shijie
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |