Messages in this thread | | | Date | Wed, 6 Feb 2013 07:15:47 +0530 | Subject | Re: [PATCH 2/7] cpufreq: Retrieve current frequency from scaling drivers with internal governors | From | Viresh Kumar <> |
| |
On Tue, Feb 5, 2013 at 11:54 PM, <dirk.brandewie@gmail.com> wrote: > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 2817c3c..96bc302 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1181,6 +1181,13 @@ unsigned int cpufreq_quick_get(unsigned int cpu) > struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); > unsigned int ret_freq = 0; > > + if (cpufreq_driver && cpufreq_driver->setpolicy && > + cpufreq_driver->get) { > + ret_freq = cpufreq_driver->get(cpu); > + cpufreq_cpu_put(policy); > + return ret_freq; > + } > +
This was my comment on the last version:
"You are required to do cpufreq_cpu_put() in this case too... Better do cpufreq_cpu_get() after your check."
It still applies.
| |