lkml.org 
[lkml]   [2013]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] mm: rename confusing function names
On Wed, Feb 06, 2013 at 01:09:55AM +0800, Zhang Yanfei wrote:
> Function nr_free_zone_pages, nr_free_buffer_pages and nr_free_pagecache_pages
> are horribly badly named, they count present_pages - pages_high within zones
> instead of free pages, so why not rename them to reasonable names, not cofusing
> people.
>
> patch2 and patch3 are based on patch1. So please apply patch1 first.
>
> Zhang Yanfei (3):
> mm: rename nr_free_zone_pages to nr_free_zone_high_pages
> mm: rename nr_free_buffer_pages to nr_free_buffer_high_pages
> mm: rename nr_free_pagecache_pages to nr_free_pagecache_high_pages

I don't feel that this is an improvement.

As you said, the "free" is already misleading, because those pages
might all be allocated. "High" makes me think not just of highmem,
but drug abuse in general.

nr_available_*_pages? I don't know, but if we go through with all
that churn, it had better improve something.


\
 
 \ /
  Last update: 2013-02-05 21:02    [W:0.098 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site