lkml.org 
[lkml]   [2013]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: For the condition "file->f_mode", when it failed, it should return EACCES rather than EBADF.
On Sun, Feb 03 2013, majianpeng wrote:
> Hi all,
> When I wanted to do discard operations,but i set the openflag was O_RDONLY,it returned a EBADF rather than EACCES or EPERM.
> I searched the code and found:
> >case BLKDISCARD:
> >case BLKSECDISCARD: {
> > uint64_t range[2];
>
> > if (!(mode & FMODE_WRITE))
> > return -EBADF;
> Initial i thought there was error.But i searched all code of kernel and found some places like this.
>
> The description of EBADF is "Bad file numbe". There are some places where returned EBADF like,
> >if (!f.file)
> > return -EBADF;
>
> So i think for checking file->f_mode when failed, it should return EACCESS.

But that would break the ABI at this point. I agree with you, though,
EBADF is not the right error for this case.

--
Jens Axboe



\
 
 \ /
  Last update: 2013-02-05 15:01    [W:0.049 / U:2.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site