lkml.org 
[lkml]   [2013]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit
On Tue, Feb 05, 2013 at 06:36:34AM +0000, Vishwanathrao Badarkhe, Manish wrote:
> I made following changes, in order to update "dip->p" pointer with
> correct value:
>
> - if (!dpi->p) {
> + if (IS_ERR_OR_NULL(dpi->p)) {
> dpi->p = devm_pinctrl_get(dev);
> - if (IS_ERR_OR_NULL(dpi->p)) {
> - int ret = PTR_ERR(dpi->p);
> -
> - dev_dbg(dev, "no pinctrl handle\n");
> - /* Only return deferrals */
> - if (ret == -EPROBE_DEFER)
> - return ret;
> - return 0;
> - }
> + ret = PTR_ERR(dpi->p);
> + dev_dbg(dev, "no pinctrl handle\n");
> + /* Only return deferrals */
> + if (ret == -EPROBE_DEFER)
> + return ret;
> + return 0;
>
> Is this intended change?

The above looks totally broken to me.

Oh, it's using IS_ERR_OR_NULL(), so it's bound to be broken.


\
 
 \ /
  Last update: 2013-02-05 13:01    [W:0.105 / U:22.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site