Messages in this thread | | | Date | Mon, 4 Feb 2013 21:35:18 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH v2 1/4] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c |
| |
On Tue, 5 Feb 2013, liguang wrote:
> srat table should present only on acpi domain, > seems mm/ is not the right place for it. > > Reviewed-by: David Rientjes <rientjes@google.com>
I certainly didn't review this, please read Documentation/SubmittingPatches.
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
Couple of issues with this:
- it doesn't include your followup change "acpi: change Makefile for srat.c building" which is required for this to build, please fold it in and repost,
- there is whitespace damage, we use tabs for indentation in Makefiles,
- you're basing your patches on Linus' tree when arch/x86/mm/srat has changed in linux-next (15 insertions(+), 14 deletions(-)), please rebase this on the linux-next tree at git.kernel.org.
Otherwise, looks good.
| |