lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] USB: storage: Define a new macro for USB storage match rules
Date
Dear  Greg:

OK,thank you very much.

Best Regards,
Franko Fang

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, February 05, 2013 2:39 AM
> To: Fangxiaozhi (Franko)
> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Xueguiying (Zihan);
> Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); balbi@ti.com;
> mdharm-usb@one-eyed-alien.net; sebastian@breakpoint.cc
> Subject: Re: [PATCH 1/2] USB: storage: Define a new macro for USB storage
> match rules
>
> On Mon, Feb 04, 2013 at 03:14:46PM +0800, fangxiaozhi 00110321 wrote:
> > +/* Define the device is matched with Vendor ID and interface
> > +descriptors */ #define UNUSUAL_VENDOR_INTF(id_vendor, cl, sc, pr, \
> > + vendorName, productName, useProtocol, useTransport, \
> > + initFunction, flags) \
> > +{ \
> > + .match_flags = USB_DEVICE_ID_MATCH_INT_INFO \
> > + | USB_DEVICE_ID_MATCH_VENDOR, \
> > + .idVendor = (id_vendor), \
> > + .bInterfaceClass = (cl), \
> > + .bInterfaceSubClass = (sc), \
> > + .bInterfaceProtocol = (pr), \
> > + .driver_info = (flags) \
> > +}
>
> I'm not going to reject this given the number of times it has been submitted,
> but can't you use the USB_VENDOR_AND_INTERFACE_INFO() macro here in
> this definition?
>
> If so, can you send me an add-on patch that makes that change?
>
> thanks,
>
> greg k-h
\
 
 \ /
  Last update: 2013-02-05 06:21    [W:0.048 / U:27.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site