lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] printk: Support for full dynticks mode
On Mon, 04 Feb 2013 21:42:02 -0500 Steven Rostedt <rostedt@goodmis.org> wrote:

> On Mon, 2013-02-04 at 18:09 -0800, Andrew Morton wrote:
>
> > I don't think so. Conceptually printk() should be "inner" to the
> > scheduler and shouldn't call into sched things at all. The (afaik
> > sole) exception to that was the klogd wakeup.
> >
> > Traditionally the deadlock happened when calling printk() with
> > tasklist_lock (now q->lock) held. printk() would call wake_up(klogd)
> > and wake_up() tries to take tasklist_lock and boom. Moving the
> > wake_up() out to the tick "thread" fixed that.
> >
> > Maybe there were other deadlock scenarios, dunno. That knowledge
> > appears to be disappearing into the mists of time :(
>
> Even without the printk irq_work the current printk method uses a
> delayed wakeup anyway.
>
> The wake_up_klogd() sets PRINTK_PENDING_WAKEUP, and the wakeup happens
> at time of the tick. I don't see where there is a deadlock.
>
> ...
>
> Do we really even need that printk_sched()?

3ccf3e8306156a282 ("printk/sched: Introduce special printk_sched() for
those awkward moments") was added _after_ wake_up_klogd() was switched
to using the printk_pending->printk_tick() thing. So presumably there
were deadlocks other than around wake_up_klogd().

The printk_pending->printk_tick() thing was added by b845b517b5e
("printk: robustify printk"), four years earlier in 2008. It says
"Avoid deadlocks against rq->lock and xtime_lock...".

So what deadlocks was the March 2012 3ccf3e830 ("printk/sched:
Introduce special printk_sched() for those awkward moments") supposed
to fix? grr. I searched my lkml archives for March 2012 and few
preceding months, but couldn't find any additional info.

> I added a printk in __sched_setscheduler() where the run queue lock is held,
> and booted that with full lockdep debugging enabled. No deadlock is
> detected.

Well, you'd need to enable various printk options to get full coverage.
For example, that xtime_lock deadlock would only have occurred when
timestamping is enabled.



\
 
 \ /
  Last update: 2013-02-05 05:41    [W:0.065 / U:1.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site