lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/5] iommu: Add domain window handling functions
From
On Mon, Feb 4, 2013 at 12:56 PM, Joerg Roedel <joro@8bytes.org> wrote:
> On Mon, Feb 04, 2013 at 12:10:51PM -0600, Stuart Yoder wrote:
>> On Mon, Feb 4, 2013 at 7:18 AM, Joerg Roedel <joro@8bytes.org> wrote:
>> > +static inline int iommu_domain_window_enable(struct iommu_domain *domain,
>> > + u32 wnd_nr, phys_addr_t paddr,
>> > + size_t size)
>> > +{
>> > + return -ENODEV;
>> > +}
>> > +
>> > +static inline void iommu_domain_window_disable(struct iommu_domain *domain,
>> > + u32 wnd_nr)
>> > +{
>> > +}
>> > +
>> > static inline phys_addr_t iommu_iova_to_phys(struct iommu_domain *domain,
>> > unsigned long iova)
>> > {
>>
>> This API looks workable. The one change we need is that the size argument in
>> the enable API needs to be 64 bits. Our window sizes can exceed 4GB.
>
> Okay. So if your architecture supports sizes over 2^32 then size_t
> probably is already 64bits, right?

No, on a 32-bit platform size_t would generally be 32-bits. But the PAMU
is independent of that. I think we should just make it a u64.

Stuart


\
 
 \ /
  Last update: 2013-02-05 01:22    [W:0.067 / U:2.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site