lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch] config: fix make kvmconfig
On Mon, 4 Feb 2013, Ingo Molnar wrote:

> > arch/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 6979498..f9459b3 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -606,6 +606,7 @@ config KVMTOOL_TEST_ENABLE
> > select NETWORK_FILESYSTEMS
> > select INET
> > select EXPERIMENTAL
> > + select TTY
> > select SERIAL_8250
> > select SERIAL_8250_CONSOLE
> > select IP_PNP
>
> There's no 'config TTY' in the kernel AFAICS.
>

It's added in linux-next by 4f73bc4dd3e8 ("tty: Added a CONFIG_TTY option
to allow removal of TTY").

Adding Greg to the cc to figure out which tree this should be merged
through. Greg, please find the patch inline.

The better alternative would be to remove KVMTOOL_TEST_ENABLE entirely
since it has been sitting in linux-next for over a year, Linus has said he
won't pull it, and it consistently needs updates both inside and outside
of Pekka's tree.

-----o<-----

config: fix make kvmconfig

make kvmconfig selects CONFIG_SERIAL_8250 without selecting its
dependencies causing some configs to fail:

drivers/tty/serial/8250/8250.c:57:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function)
drivers/tty/serial/8250/8250.c:2712:47: error: 'CONFIG_SERIAL_8250_NR_UARTS' undeclared here (not in a function)
drivers/tty/serial/8250/8250.c: In function 'serial8250_console_write':
drivers/tty/serial/8250/8250.c:2843:10: error: 'struct uart_port' has no member named 'sysrq'
drivers/tty/serial/8250/8250.c: In function 'early_serial_setup':
drivers/tty/serial/8250/8250.c:2971:20: error: negative width in bit-field '<anonymous>'
drivers/tty/serial/8250/8250.c: At top level:
drivers/tty/serial/8250/8250.c:2712:30: warning: 'serial8250_ports' defined but not used [-Wunused-variable]

Fix this by selecting CONFIG_TTY as well, which CONFIG_SERIAL_8250
requires.

Signed-off-by: David Rientjes <rientjes@google.com>
---
arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 6979498..f9459b3 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -606,6 +606,7 @@ config KVMTOOL_TEST_ENABLE
select NETWORK_FILESYSTEMS
select INET
select EXPERIMENTAL
+ select TTY
select SERIAL_8250
select SERIAL_8250_CONSOLE
select IP_PNP

\
 
 \ /
  Last update: 2013-02-04 20:42    [W:0.091 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site