lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()
Hey,

On Mon, Feb 04, 2013 at 01:10:34PM -0500, chas williams - CONTRACTOR wrote:
> you assign id1 to 0, so this never happens i think. i don't think the
> reason to preassign id1/id2 exists anymore once the do loop is removed.
>
> > + id1 = idr_alloc(&card->idr, handle1, 0, 0, GFP_ATOMIC);
> > + if (id1 < 0) {
> > + err = id1;
>
> you dont need to assign err since it isn't returned.

Heh, I put v2 under the wrong thread. I'll do v3 and post it under
v1.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-02-04 20:23    [W:0.046 / U:5.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site