lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12.5/62] firewire: add minor number range check to fw_device_init()
On Feb 04 Tejun Heo wrote:
> fw_device_init() didn't check whether the allocated minor number isn't
> too large. Fail if it goes overflows MINORBITS.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Suggested-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Cc: stable@vger.kernel.org
> ---
> drivers/firewire/core-device.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- a/drivers/firewire/core-device.c
> +++ b/drivers/firewire/core-device.c
> @@ -1020,6 +1020,10 @@ static void fw_device_init(struct work_s
> ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
> idr_get_new(&fw_device_idr, device, &minor) :
> -ENOMEM;
> + if (minor >= 1 << MINORBITS) {
> + idr_remove(&fw_device_idr, minor);
> + minor = -ENOSPC;
> + }
> up_write(&fw_device_rwsem);
>
> if (ret < 0)

Thanks; routing together with the other idr patches through mm Acked-by:
Stefan Richter <stefanr@s5r6.in-berlin.de>

Not totally sure whether to bother -stable with this, as this condition is
rather difficult to provoke. But since the fix is small and "obvious",
why not.
--
Stefan Richter
-=====-===-= --=- --=--
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2013-02-04 20:01    [W:0.136 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site