lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] leds-ot200: Fix error caused by shifted mask
2013/2/1 Andrew Morton <akpm@linux-foundation.org>:
> On Fri, 1 Feb 2013 16:08:15 +0100
> Christian Gmeiner <christian.gmeiner@gmail.com> wrote:
>
>> ping
>
> Bryan is handling LEDs patches (see ./MAINTAINERS). Without a cc he
> presumably missed this in the lkml flood.

You are right...

~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c
Bryan Wu <cooloney@gmail.com> (maintainer:LED SUBSYSTEM)
Richard Purdie <rpurdie@rpsys.net> (maintainer:LED SUBSYSTEM)
linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

Next time I will add Bryan to CC

>
>> 2013/1/23 GMEINER.Christian <C.GMEINER@bachmann.info>:
>> >> -----Urspr__ngliche Nachricht-----
>> >> Von: Christian Gmeiner [mailto:christian.gmeiner@gmail.com]
>> >> Gesendet: Mittwoch, 23. Januar 2013 09:11
>> >> An: linux-next@vger.kernel.org; akpm@linux-foundation.org;
>> >> rpurdie@rpsys.net; linux-kernel@vger.kernel.org; GMEINER.Christian
>> >> Cc: Christian Gmeiner
>> >> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
>> >>
>> >> During the development of this driver an in-house register documentation
>> >> was used. The last weeks some integration tests were done and this problem
>> >> was found. It turned out that the released register documentation is wrong.
>> >>
>> >> The fix is very simple: shift all masks by one.
>> >>
>
> The changelog failed to describe the effects of the bug it fixes. This
> is a grave (and all too common) omission; it makes it difficult for
> others to determine whether the patch should be backported into earlier
> kernels.
>
> So, please tell us. And feel free to explain whether you believe the
> fix should be backported.

Our customers can control LEDs from userspace via Java, C++ or what every. They
have running/working applications where they want to control led_3 but
led_2 get's
used. I got a bug report in our in-house bug tracker so it would be
great if this patch can make it into 3.7.x series.

thanks
--
Christian Gmeiner, MSc


\
 
 \ /
  Last update: 2013-02-04 16:45    [W:0.080 / U:9.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site