lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] fs: Take mapping lock in generic read paths
On Thu 31-01-13 15:59:40, Andrew Morton wrote:
> On Thu, 31 Jan 2013 22:49:50 +0100
> Jan Kara <jack@suse.cz> wrote:
>
> > Add mapping lock to struct address_space and grab it in all paths
> > creating pages in page cache to read data into them. That means buffered
> > read, readahead, and page fault code.
>
> Boy, this does look expensive in both speed and space.
I'm not sure I'll be able to do much with the space cost but hopefully
the CPU cost could be reduced.

> As you pointed out in [0/n], it's 2-3%. As always with pagecache
> stuff, the cost of filling the page generally swamps any inefficiencies
> in preparing that page.
Yes, I measured it with with ramdisk backed fs exactly to remove the cost
of filling the page from the picture. But there are systems where IO is CPU
bound (e.g. when you have PCIe attached devices) and although there is the
additional cost of block layer which will further hide the cost of page
cache itself I assume the added 2-3% incurred by page cache itself will be
measurable on such systems. So that's why I'd like to reduce the CPU cost
of range locking.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2013-02-04 14:22    [W:0.084 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site