lkml.org 
[lkml]   [2013]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function
Date
Hi Mark/Liam,

Any comments in this?

Regards,
Keerthy

-----Original Message-----
From: J, KEERTHY
Sent: Friday, February 01, 2013 10:35 AM
To: linux-kernel@vger.kernel.org; lgirdwood@gmail.com; broonie@opensource.wolfsonmicro.com
Cc: J, KEERTHY
Subject: [PATCH] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function

The min and max values for regulators are getting assigned before actually
the voltage is set. So making sure that min and max values are assigned
only if the voltage is successfully set else keeping the last successfully
set voltage's min and max values.

This is boot tested on OMAP4430 and OMAP4460 boards.

Signed-off-by: J Keerthy <j-keerthy@ti.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/core.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 2785843..12140fb 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -81,6 +81,8 @@ struct regulator {
int uA_load;
int min_uV;
int max_uV;
+ int curr_min_uV;
+ int curr_max_uV;
char *supply_name;
struct device_attribute dev_attr;
struct regulator_dev *rdev;
@@ -2315,6 +2317,8 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
ret = regulator_check_voltage(rdev, &min_uV, &max_uV);
if (ret < 0)
goto out;
+ regulator->curr_min_uV = regulator->min_uV;
+ regulator->curr_max_uV = regulator->max_uV;
regulator->min_uV = min_uV;
regulator->max_uV = max_uV;

@@ -2325,6 +2329,11 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV)
ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);

out:
+ if (ret) {
+ regulator->min_uV = regulator->curr_min_uV;
+ regulator->max_uV = regulator->curr_max_uV;
+ }
+
mutex_unlock(&rdev->mutex);
return ret;
}
--
1.7.5.4


\
 
 \ /
  Last update: 2013-02-04 13:44    [W:0.095 / U:4.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site