lkml.org 
[lkml]   [2013]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] x86, 32-bit: Drop new_cpu_data
On 02/03/2013 08:14 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> We copy it to boot_cpu_data anyway so use boot_cpu_data from the get-go.
>

Hmm... this is the only part of this patchset I feel skeptical towards.
Overall, a lot of the early SMP code went way out of its way to have
zero impact on the !CONFIG_SMP case, but that was a long time ago.
Nowadays what we really should have is cpu_data being a percpu variable
separate from boot_cpu_data (which is really "all_cpu_data") even on UP.

Another cleanup desperately needed in this area is a bitvector for bugs
in addition to features. In fact, I kind of suspect we should make it
the *same* bitvector (different words) so we cpu_has(X) works on both
without confusion (just put the BUGS at the end; it means that if we add
feature words the bug numbers will shift but that is okay.)

I actually mean to do this when I did the CPU feature vector stuff over
10 years ago, but never got around to it... and it still has never
gotten done.

The difference between bugs and features, of course, is that the former
should be combined across CPUs with an OR whereas the latter get
combined with an AND.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2013-02-04 01:21    [W:0.154 / U:1.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site