Messages in this thread Patch in this message | | | From | Peter Huewe <> | Subject | [PATCH 04/10] staging/xgifb: Fix return of uninitialized variable | Date | Sun, 3 Feb 2013 22:54:33 +0100 |
| |
Clang warning: drivers/staging/xgifb/XGI_main_26.c: warning: variable 'ret' is used uninitialized whenever 'if' condition: if (xgifb_info->mode_idx < 0) { evaluates to true.
drivers/staging/xgifb/XGI_main_26.c: note: uninitialized use occurs here return ret;
This patch initializes the variable in this case.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/staging/xgifb/XGI_main_26.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index fa351f9..106abc8 100644 --- a/drivers/staging/xgifb/XGI_main_26.c +++ b/drivers/staging/xgifb/XGI_main_26.c @@ -1921,6 +1921,7 @@ static int xgifb_probe(struct pci_dev *pdev, if (xgifb_info->mode_idx < 0) { dev_err(&pdev->dev, "No supported video mode found\n"); + ret = -EINVAL; goto error_1; } -- 1.7.8.6
| |