lkml.org 
[lkml]   [2013]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/30] staging: sync: Export sync API symbols
On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote:
> From: Erik Gilling <konkers@android.com>
>
> This is needed to allow modules to link against the sync subsystem
>
> Cc: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> Cc: Erik Gilling <konkers@android.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Rob Clark <robclark@gmail.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Android Kernel Team <kernel-team@android.com>
> Signed-off-by: Erik Gilling <konkers@android.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/staging/android/sync.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
> index 54f84d9..6739a84 100644
> --- a/drivers/staging/android/sync.c
> +++ b/drivers/staging/android/sync.c
> @@ -15,6 +15,7 @@
> */
>
> #include <linux/debugfs.h>
> +#include <linux/export.h>
> #include <linux/file.h>
> #include <linux/fs.h>
> #include <linux/kernel.h>
> @@ -64,6 +65,7 @@ struct sync_timeline *sync_timeline_create(const struct sync_timeline_ops *ops,
>
> return obj;
> }
> +EXPORT_SYMBOL(sync_timeline_create);

As these are now global, should they be a bit more "specific"? "sync_"
seems pretty broad.

Also, EXPORT_SYMBOL_GPL() perhaps?

And who is using these exports?

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-03-01 03:41    [W:0.244 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site