Messages in this thread | | | Date | Wed, 27 Feb 2013 21:19:50 -0500 | From | Andrew Shewmaker <> | Subject | Re: [RFC PATCH v2 2/2] mm: tuning hardcoded reserved memory |
| |
On Thu, Feb 28, 2013 at 02:14:41PM -0800, Andrew Morton wrote: > On Wed, 27 Feb 2013 16:09:25 -0500 > Andrew Shewmaker <agshew@gmail.com> wrote: > > > Add a rootuser_reserve_pages knob to allow admins of large memory > > systems running with overcommit disabled to change the hardcoded > > memory reserve to something other than 3%. > > > > Signed-off-by: Andrew Shewmaker <agshew@gmail.com> > > > > --- > > > > Patch based off of mmotm git tree as of February 27th. > > > > I set rootuser_reserve pages to be a default of 1000, and I suppose > > I should have initialzed similarly to the way min_free_kbytes is, > > scaling it with the size of the box. However, I wanted to get a > > simple version of this patch out for feedback to see if it has any > > chance of acceptance or if I need to take an entirely different > > approach. > > > > Any feedback will be appreciated! > > Seems reasonable. > > Yes, we should scale the initial value according to the machine size in > some fashion. > > btw, both these patches had the same title. Please avoid this. > Documentation/SubmittingPatches section 15 has all the details.
Sorry about that. I'll resend correctly formatted patche submissions with a scaled initial value for rootuser_reserve_pages.
Thanks for the feedback!
| |