lkml.org 
[lkml]   [2013]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v3 3/6] uretprobes: generalize xol_get_insn_slot()
    Anton, I'll try to read this series asap. Just one note,

    On 02/28, Anton Arapov wrote:
    >
    > Generalize xol_take_insn_slot() to enable more consumers of the
    > function, e.g. trampoline implementation for return probes.

    Yes, this is can work too.

    But I guess you misunderstood me, or I missed something...

    Why do you need xol_area->rp_trampoline_vaddr at all? From the very
    beginning I am trying to suggest to use the first slot for trampoline:

    Or. Perhaps even better, do not add this helper at all. xol_alloc_area()
    could reserve the first slot/bit for trampoline. And note that in this
    case we do not need xol_area->rp_trampoline_vaddr, it is always equal
    to xol_area->vaddr.

    Doesn't this look simpler?

    Oleg.



    \
     
     \ /
      Last update: 2013-02-28 21:41    [W:4.910 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site