Messages in this thread | | | Date | Wed, 27 Feb 2013 18:01:16 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] drivers/net/wireless/ath/wil6210: Makefile, only -Werror when no -W* in EXTRA_CFLAGS |
| |
于 2013年02月27日 17:46, Vladimir Kondratiev 写道: > Perhaps, it would be good idea to fight the original problem. >
if my another 'beautify code' patches are applied into next-* tree. (that means most of members think it is a good idea). I will process the original problems (when processing, also cc to you).
:-)
> I mean, fix warnings where possible. Example: there are lots of > "unused parameter" ones. Where it is false warning, add __maybe_unused > attribute. Like this: > > diff --git a/include/linux/kernel.h b/include/linux/kernel.h > index c566927..83e43b7 100644 > --- a/include/linux/kernel.h > +++ b/include/linux/kernel.h > @@ -163,8 +163,9 @@ extern int _cond_resched(void); > # define might_sleep() \ > do { __might_sleep(__FILE__, __LINE__, 0); might_resched(); } while (0) > #else > - static inline void __might_sleep(const char *file, int line, > - int preempt_offset) { } > + static inline void __might_sleep(const char *file __maybe_unused, > + int line __maybe_unused, > + int preempt_offset __maybe_unused) { } > # define might_sleep() do { might_resched(); } while (0) > #endif >
thank you for your demo, it is valuable to me.
:-)
-- Chen Gang
Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |