lkml.org 
[lkml]   [2013]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 28/53] ext4: add missing kfree() on error return path in add_new_gdb()
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <error27@gmail.com>

    commit c49bafa3842751b8955a962859f42d307673d75d upstream.

    We added some more error handling in b40971426a "ext4: add error
    checking to calls to ext4_handle_dirty_metadata()". But we need to
    call kfree() as well to avoid a memory leak.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Jeff Mahoney <jeffm@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


    ---
    fs/ext4/resize.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/ext4/resize.c
    +++ b/fs/ext4/resize.c
    @@ -499,6 +499,7 @@ static int add_new_gdb(handle_t *handle,
    return err;

    exit_inode:
    + kfree(n_group_desc);
    /* ext4_handle_release_buffer(handle, iloc.bh); */
    brelse(iloc.bh);
    exit_dindj:



    \
     
     \ /
      Last update: 2013-02-27 02:21    [W:2.296 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site