Messages in this thread | | | Date | Thu, 21 Feb 2013 10:10:48 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] idr: explain WARN_ON_ONCE() on negative IDs out-of-range ID |
| |
On Wed, 20 Feb 2013, Tejun Heo wrote:
> Until recently, when an negative ID is specified, idr functions used > to ignore the sign bit and proceeded with the operation with the rest > of bits, which is bizarre and error-prone. The behavior recently got > changed so that negative IDs are treated as invalid but we're > triggering WARN_ON_ONCE() on negative IDs just in case somebody was > depending on the sign bit being ignored, so that those can be detected > and fixed easily. > > We only need this for a while. Explain why WARN_ON_ONCE()s are there > and that they can be removed later. > > Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by : Thomas Gleixner <tglx@linutronix.de>
| |