lkml.org 
[lkml]   [2013]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] idr: explain WARN_ON_ONCE() on negative IDs out-of-range ID
On Wed, 20 Feb 2013, Tejun Heo wrote:

> Until recently, when an negative ID is specified, idr functions used
> to ignore the sign bit and proceeded with the operation with the rest
> of bits, which is bizarre and error-prone. The behavior recently got
> changed so that negative IDs are treated as invalid but we're
> triggering WARN_ON_ONCE() on negative IDs just in case somebody was
> depending on the sign bit being ignored, so that those can be detected
> and fixed easily.
>
> We only need this for a while. Explain why WARN_ON_ONCE()s are there
> and that they can be removed later.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>

Acked-by : Thomas Gleixner <tglx@linutronix.de>


\
 
 \ /
  Last update: 2013-02-21 10:45    [W:0.114 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site