Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH V2 1/4] cpufreq: Add per policy governor-init/exit infrastructure | Date | Fri, 22 Feb 2013 03:21:51 +0100 |
| |
On Friday, February 22, 2013 07:38:12 AM Viresh Kumar wrote: > On 22 February 2013 05:05, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > On Monday, February 11, 2013 01:20:00 PM Viresh Kumar wrote: > > >> This patch is inclined towards providing this infrastructure. Because we are > >> required to allocate governor's resources dynamically now, we must do it at > >> policy creation and end. And so got CPUFREQ_GOV_POLICY_INIT/EXIT. > > > > Are those new events NOPs now? > > No. These are used atleast for ondemand & conservative.
They will be after the next patch, you mean? :-)
> >> +#define CPUFREQ_GOV_POLICY_INIT 4 > >> +#define CPUFREQ_GOV_POLICY_EXIT 4 > > > > Why don't you use different values here? > > > > If you need only one value, one #define should be sufficient. > > Naah, something happened... I got fixed this locally but couldn't > get that into the commit somehow. EXIT should have 5 here.
Well, it appeared so from the next patch ...
Thanks, Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |