lkml.org 
[lkml]   [2013]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 11/32] n_tty: Correct unthrottle-with-buffer-flush comments
    Date
    The driver is no longer unthrottled on buffer reset, so remove
    comments that claim it is.

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/tty/n_tty.c | 13 +++++--------
    1 file changed, 5 insertions(+), 8 deletions(-)

    diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
    index 0b85693..a786f4e 100644
    --- a/drivers/tty/n_tty.c
    +++ b/drivers/tty/n_tty.c
    @@ -213,9 +213,8 @@ static void check_unthrottle(struct tty_struct *tty)
    * reset_buffer_flags - reset buffer state
    * @tty: terminal to reset
    *
    - * Reset the read buffer counters, clear the flags,
    - * and make sure the driver is unthrottled. Called
    - * from n_tty_open() and n_tty_flush_buffer().
    + * Reset the read buffer counters and clear the flags.
    + * Called from n_tty_open() and n_tty_flush_buffer().
    *
    * Locking: tty_read_lock for read fields.
    */
    @@ -254,17 +253,15 @@ static void n_tty_packet_mode_flush(struct tty_struct *tty)
    * n_tty_flush_buffer - clean input queue
    * @tty: terminal device
    *
    - * Flush the input buffer. Called when the line discipline is
    - * being closed, when the tty layer wants the buffer flushed (eg
    - * at hangup) or when the N_TTY line discipline internally has to
    - * clean the pending queue (for example some signals).
    + * Flush the input buffer. Called when the tty layer wants the
    + * buffer flushed (eg at hangup) or when the N_TTY line discipline
    + * internally has to clean the pending queue (for example some signals).
    *
    * Locking: ctrl_lock, read_lock.
    */

    static void n_tty_flush_buffer(struct tty_struct *tty)
    {
    - /* clear everything and unthrottle the driver */
    reset_buffer_flags(tty);

    if (tty->link)
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-02-20 22:44    [W:4.068 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site