Messages in this thread | | | Subject | Re: [RFC PATCH v3 1/3] sched: schedule balance map foundation | From | Peter Zijlstra <> | Date | Wed, 20 Feb 2013 14:21:02 +0100 |
| |
On Tue, 2013-01-29 at 17:09 +0800, Michael Wang wrote: > + for_each_possible_cpu(cpu) { > + sbm = &per_cpu(sbm_array, cpu); > + node = cpu_to_node(cpu); > + size = sizeof(struct sched_domain *) * sbm_max_level; > + > + for (type = 0; type < SBM_MAX_TYPE; type++) { > + sbm->sd[type] = kmalloc_node(size, GFP_KERNEL, > node); > + WARN_ON(!sbm->sd[type]); > + if (!sbm->sd[type]) > + goto failed; > + } > + }
You can't readily use kmalloc_node() here, cpu_to_node() might return an invalid node for offline cpus here.
Also see: 2ea45800d8e1c3c51c45a233d6bd6289a297a386
| |