lkml.org 
[lkml]   [2013]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 15/16] virtio_balloon: use simplified virtqueue accessors.
    On 02/19/2013 03:56 PM, Rusty Russell wrote:
    > We never add buffers with input and output parts, so use the new accessors.
    >
    > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

    Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

    > ---
    > drivers/virtio/virtio_balloon.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
    > index 8dab163..bd3ae32 100644
    > --- a/drivers/virtio/virtio_balloon.c
    > +++ b/drivers/virtio/virtio_balloon.c
    > @@ -108,7 +108,7 @@ static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq)
    > sg_init_one(&sg, vb->pfns, sizeof(vb->pfns[0]) * vb->num_pfns);
    >
    > /* We should always be able to add one buffer to an empty queue. */
    > - if (virtqueue_add_buf(vq, &sg, 1, 0, vb, GFP_KERNEL) < 0)
    > + if (virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL) < 0)
    > BUG();
    > virtqueue_kick(vq);
    >
    > @@ -256,7 +256,7 @@ static void stats_handle_request(struct virtio_balloon *vb)
    > if (!virtqueue_get_buf(vq, &len))
    > return;
    > sg_init_one(&sg, vb->stats, sizeof(vb->stats));
    > - if (virtqueue_add_buf(vq, &sg, 1, 0, vb, GFP_KERNEL) < 0)
    > + if (virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL) < 0)
    > BUG();
    > virtqueue_kick(vq);
    > }
    > @@ -341,7 +341,7 @@ static int init_vqs(struct virtio_balloon *vb)
    > * use it to signal us later.
    > */
    > sg_init_one(&sg, vb->stats, sizeof vb->stats);
    > - if (virtqueue_add_buf(vb->stats_vq, &sg, 1, 0, vb, GFP_KERNEL)
    > + if (virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, GFP_KERNEL)
    > < 0)
    > BUG();
    > virtqueue_kick(vb->stats_vq);
    >



    \
     
     \ /
      Last update: 2013-02-20 12:21    [W:6.276 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site