lkml.org 
[lkml]   [2013]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 4/4] devcg: propagate local changes down the hierarchy
On Tue, Feb 19, 2013 at 09:12:08PM +0000, Serge E. Hallyn wrote:
> Quoting Aristeu Rozanski (aris@redhat.com):
> > + } else {
> > + /*
> > + * in the other possible cases:
> > + * root's behavior: allow, devcg's: deny
> > + * root's behavior: deny, devcg's: deny
> > + * the exception will be removed
> > + */
>
> Technically this case isn't needed, right? Will the dev_exception_rm()
> also be done by revalidate_active_exceptions()? So it's safe (but
> not necessary) to drop the else here. Though the comment is very
> informative, and it might be worth keeping the code as is for clarity.

that's correct, it'll end up being removed by
revalidate_active_exceptions(). if others have no objection, I'll keep
it

Thanks for the reviews Serge, much appreciated

--
Aristeu



\
 
 \ /
  Last update: 2013-02-19 23:02    [W:0.056 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site