Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio | Date | Tue, 19 Feb 2013 09:00:13 +1030 |
| |
Sjur Brændeland <sjurbren@gmail.com> writes:
>> Sjur Brændeland <sjurbren@gmail.com> writes: >>> How about supporting struct vringh_kiov and struct kvec as well? >>> I currently get the following complaints with my V2 patch-set: >>> >>> drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of >>> ‘vringh_iov_init’ from incompatible pointer type [enabled by default] >> >> vringh_kiov_init()? Did I miss something else? > > I get a warning for my useof vringh_iov_cleanup() in > addition to the one above. > > How about adding kiov variants of vringh_iov_cleanup() > and vringh_iov_reset() as well?
Hmm, I have those here too (in the header):
+static inline void vringh_kiov_reset(struct vringh_kiov *kiov) +{ + kiov->off = 0; + kiov->i = 0; +} + +static inline void vringh_kiov_cleanup(struct vringh_kiov *kiov) +{ + if (kiov->max_num & VRINGH_IOV_ALLOCATED) + kfree(kiov->iov); + kiov->max_num = kiov->used = kiov->i = kiov->off = 0; + kiov->iov = NULL; +}
I've folded the patches and put them into my pending-rebases branch, ready for virtio-next.
I'd really like MST's ack on this, too, so I'll repost the series.
Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |